Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5EBC10333 for ; Fri, 28 Jun 2013 21:39:28 +0000 (UTC) Received: (qmail 15016 invoked by uid 500); 28 Jun 2013 21:39:28 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 14988 invoked by uid 500); 28 Jun 2013 21:39:28 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 14978 invoked by uid 500); 28 Jun 2013 21:39:28 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 14968 invoked by uid 99); 28 Jun 2013 21:39:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jun 2013 21:39:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C86B71CD27D; Fri, 28 Jun 2013 21:39:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6838253775140338793==" MIME-Version: 1.0 Subject: Review Request 12180: Fix NPE when adding invalid primary datastore From: "Venkata Siva Vijayendra Bhamidipati" To: "Kelven Yang" , "Sateesh Chodapuneedi" , "Chip Childers" , "Devdeep Singh" Cc: "Venkata Siva Vijayendra Bhamidipati" , "cloudstack" Date: Fri, 28 Jun 2013 21:39:19 -0000 Message-ID: <20130628213919.23542.99241@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Venkata Siva Vijayendra Bhamidipati" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12180/ X-Sender: "Venkata Siva Vijayendra Bhamidipati" Reply-To: "Venkata Siva Vijayendra Bhamidipati" --===============6838253775140338793== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/ ----------------------------------------------------------- Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-3110 Repository: cloudstack-git Description ------- Fixing an NPE when an attempt is made to add a primary datastore by providing an unreachable/nonexistent datastore/host. Diffs ----- engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java b92f92f engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java 06b54e0 Diff: https://reviews.apache.org/r/12180/diff/ Testing ------- With fix in place, an attempt to add an invalid primary datastore will fail with a GUI error dialog instead of failing silently with an NPE in the mgmt server log. Thanks, Venkata Siva Vijayendra Bhamidipati --===============6838253775140338793==--