Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE304106A2 for ; Thu, 27 Jun 2013 21:10:11 +0000 (UTC) Received: (qmail 58417 invoked by uid 500); 27 Jun 2013 21:10:11 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 58373 invoked by uid 500); 27 Jun 2013 21:10:11 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 58363 invoked by uid 500); 27 Jun 2013 21:10:11 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 58354 invoked by uid 99); 27 Jun 2013 21:10:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2013 21:10:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDF011CD1F6; Thu, 27 Jun 2013 21:10:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5993093384957339242==" MIME-Version: 1.0 Subject: Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able to register template From: "ASF Subversion and Git Services" To: "Abhinandan Prateek" , "Alena Prokharchyk" Cc: "cloudstack" , "Harikrishna Patnala" , "ASF Subversion and Git Services" Date: Thu, 27 Jun 2013 21:10:02 -0000 Message-ID: <20130627211002.23541.59678@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/12136/ X-Sender: "ASF Subversion and Git Services" References: <20130627190443.23542.630@reviews.apache.org> In-Reply-To: <20130627190443.23542.630@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============5993093384957339242== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12136/#review22487 ----------------------------------------------------------- Commit c8692f2e4a9760a58dbf457bf128fa484a491d0d in branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8692f2 ] CLOUDSTACK-3245: non admin user not able to register template Reviewed-by: Alena Prokharchyk - ASF Subversion and Git Services On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12136/ > ----------------------------------------------------------- > > (Updated June 27, 2013, 7:04 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek. > > > Bugs: CLOUDSTACK-3245 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3245: non admin user not able to register template > > During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da > server/src/com/cloud/template/TemplateAdapterBase.java 7835680 > > Diff: https://reviews.apache.org/r/12136/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > > --===============5993093384957339242==--