Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBE4B1044F for ; Thu, 20 Jun 2013 05:36:00 +0000 (UTC) Received: (qmail 50590 invoked by uid 500); 20 Jun 2013 05:35:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 50504 invoked by uid 500); 20 Jun 2013 05:35:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 50490 invoked by uid 500); 20 Jun 2013 05:35:55 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 50482 invoked by uid 99); 20 Jun 2013 05:35:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jun 2013 05:35:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A421A1CCD3A; Thu, 20 Jun 2013 05:35:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4984094592166529281==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order. From: "ASF Subversion and Git Services" To: "Devdeep Singh" Cc: "Saksham Srivastava" , "cloudstack" , "ASF Subversion and Git Services" Date: Thu, 20 Jun 2013 05:35:47 -0000 Message-ID: <20130620053547.29623.309@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11708/ X-Sender: "ASF Subversion and Git Services" References: <20130619113739.32008.94678@reviews.apache.org> In-Reply-To: <20130619113739.32008.94678@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============4984094592166529281== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11708/#review22150 ----------------------------------------------------------- Commit fd77b60c5d3a3a5029d40583d4fc391e0cb41253 in branch refs/heads/master= -6-17-stable from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3Dfd77b60 ] CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order - ASF Subversion and Git Services On June 19, 2013, 11:37 a.m., Saksham Srivastava wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11708/ > ----------------------------------------------------------- > = > (Updated June 19, 2013, 11:37 a.m.) > = > = > Review request for cloudstack and Devdeep Singh. > = > = > Description > ------- > = > When multiple vlan ranges are added to a physical networks the vlan range= s displayed in the output of the listPhysicalNetworks api displays the vlan= range in the order the ranges were added,Instead if they are displayed in = the ascending order range this would make it easy for the end user. > = > = > This addresses bug CLOUDSTACK-2167. > = > = > Diffs > ----- > = > server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f = > = > Diff: https://reviews.apache.org/r/11708/diff/ > = > = > Testing > ------- > = > The response of list api is now enhanced: > > 1 > > 49e5cdfc-2c14-415a-9dd3-38ac2fdeef54 > Physical Network 1 > ZONE > 0bd17058-2931-479b-98b5-29c8c91c24d3 > Enabled > 480-504;910-914;916-918;920-923;925-934;936-940 > VLAN > > > Build passes successfully. > = > = > Thanks, > = > Saksham Srivastava > = > --===============4984094592166529281==--