Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 125F010914 for ; Wed, 19 Jun 2013 06:50:27 +0000 (UTC) Received: (qmail 45215 invoked by uid 500); 19 Jun 2013 06:50:25 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 45181 invoked by uid 500); 19 Jun 2013 06:50:25 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 45170 invoked by uid 500); 19 Jun 2013 06:50:24 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 45160 invoked by uid 99); 19 Jun 2013 06:50:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2013 06:50:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BEFDE1CCCD1; Wed, 19 Jun 2013 06:50:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9215669110960761176==" MIME-Version: 1.0 Subject: Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status From: "roxanne chang" To: "edison su" , "Abhinandan Prateek" , "Nitin Mehta" Cc: "Prasanna Santhanam" , "Animesh Chaturvedi" , "cloudstack" , "roxanne chang" Date: Wed, 19 Jun 2013 06:50:16 -0000 Message-ID: <20130619065016.32008.55484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "roxanne chang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9818/ X-Sender: "roxanne chang" References: <20130619064530.32008.63954@reviews.apache.org> In-Reply-To: <20130619064530.32008.63954@reviews.apache.org> Reply-To: "roxanne chang" --===============9215669110960761176== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/ ----------------------------------------------------------- (Updated June 19, 2013, 6:50 a.m.) Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and edison = su. Changes ------- add Nitin Description ------- Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if= the host type is Secondary storage VM, the logic is to set secondarystorag= e host, at this time, secondarystorage host stauts should become Up. The secondary storage host always remains Alert status, because before the = secondary storage vm is deployed, the secondary storage host is created. Th= e tricky way (in the end of file AgentManagerImpl.java, function NotifiMoni= torsOfConnection) will try to disconnect secondary storage, therefore the s= econdary storage host becomes Alert status. The code should take SSVM into = consider, not only Answer reponse. File ResourceManagerImpl.java, function discoverHostsFull, in the end will = call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscove= ry, the condition _userServiceVM is not needed since its use to make second= ary storage host wait for SSVM is already done in SecondaryStorageManagerIm= pl. This makes why secondary storage host always remains Alert status. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594. Diffs ----- server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf = server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java c= 343286 = services/secondary-storage/src/org/apache/cloudstack/storage/resource/Sec= ondaryStorageDiscoverer.java d3af792 = Diff: https://reviews.apache.org/r/9818/diff/ Testing ------- Test 4.0.0, 4.2.0 in basic mode, works well. Thanks, roxanne chang --===============9215669110960761176==--