Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B61F1013C for ; Tue, 18 Jun 2013 13:57:56 +0000 (UTC) Received: (qmail 10389 invoked by uid 500); 18 Jun 2013 13:31:16 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 10356 invoked by uid 500); 18 Jun 2013 13:31:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 10346 invoked by uid 500); 18 Jun 2013 13:31:12 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 10333 invoked by uid 99); 18 Jun 2013 13:31:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 13:31:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6FDDF1C28E6; Tue, 18 Jun 2013 13:31:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3299268139577034297==" MIME-Version: 1.0 Subject: Re: Review Request: remove duplicated VPC router in return value of DomainRouterDaoImpl.listByStateAndNetworkType From: "Wei Zhou" To: "cloudstack" , "Chip Childers" , "Wei Zhou" Date: Tue, 18 Jun 2013 13:31:02 -0000 Message-ID: <20130618133102.32192.20388@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Wei Zhou" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10062/ X-Sender: "Wei Zhou" References: <20130617184430.32192.33459@reviews.apache.org> In-Reply-To: <20130617184430.32192.33459@reviews.apache.org> Reply-To: "Wei Zhou" --===============3299268139577034297== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 17, 2013, 6:44 p.m., Chip Childers wrote: > > Wei, > > = > > Should this still be applied? If so, can you go ahead and do it (remem= ber, 4.0 is not going to see another non-security release). > > = > > If not, can you please close this review? > > = > > -chip Chip, I just changed and committed it. Thanks. -Wei - Wei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10062/#review22007 ----------------------------------------------------------- On March 22, 2013, 6:22 a.m., Wei Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10062/ > ----------------------------------------------------------- > = > (Updated March 22, 2013, 6:22 a.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > The return value of listByStateAndNetworkType function in server/src/com/= cloud/vm/dao/DomainRouterDaoImpl.java contains duplicated VPC router. > For example, if a VPC contains 3 tiers, the return value contains 3 VPC r= outers. > = > We need to get only one VPC router for a VPC. > = > This patch applies on 4.0.1. I will create a patch for master/4.1 later. > = > = > Diffs > ----- > = > server/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 175d3f2 = > = > Diff: https://reviews.apache.org/r/10062/diff/ > = > = > Testing > ------- > = > Testing manually ok. > = > = > Thanks, > = > Wei Zhou > = > --===============3299268139577034297==--