Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73F83109FB for ; Tue, 18 Jun 2013 07:05:37 +0000 (UTC) Received: (qmail 39680 invoked by uid 500); 18 Jun 2013 07:05:36 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 39466 invoked by uid 500); 18 Jun 2013 07:05:36 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 39454 invoked by uid 500); 18 Jun 2013 07:05:35 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 39444 invoked by uid 99); 18 Jun 2013 07:05:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 07:05:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 637D71CCC58; Tue, 18 Jun 2013 07:05:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2348825304337160979==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm From: "Harikrishna Patnala" To: "Abhinandan Prateek" , "Nitin Mehta" Cc: "cloudstack" , "Harikrishna Patnala" , "Prasanna Santhanam" Date: Tue, 18 Jun 2013 07:05:25 -0000 Message-ID: <20130618070525.32008.67@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Harikrishna Patnala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11910/ X-Sender: "Harikrishna Patnala" References: <20130617183738.32192.88715@reviews.apache.org> In-Reply-To: <20130617183738.32192.88715@reviews.apache.org> Reply-To: "Harikrishna Patnala" --===============2348825304337160979== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ ----------------------------------------------------------- (Updated June 18, 2013, 7:05 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes ------- Added upgrade case. Added case insensitivity for the flag we use to check scalability of VM. Description ------- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dy= namic scaling of vm = CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence = of XS tools in the template This should also take care of updation of VM after XS tools are installed i= n the vm and set memory values accordingly to support dynamic scaling after= stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs (updated) ----- api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b = api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 = api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c = api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 = api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 28= 4d553 = api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateC= md.java c9da0c2 = api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 286028= 3 = api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a = api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a = core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 = engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 = engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc = engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl= .java 4d162bb = plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a= 69 = plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResou= rceBase.java 5e8283a = plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56= FP1Resource.java 8e37809 = server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c = server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d = server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd = server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f = server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 = server/src/com/cloud/storage/TemplateProfile.java 0b55f1f = server/src/com/cloud/template/TemplateAdapter.java 9a2d877 = server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e = server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 = server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 = server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e = setup/db/db/schema-410to420.sql 272fc42 = Diff: https://reviews.apache.org/r/11910/diff/ Testing ------- Tested locally Thanks, Harikrishna Patnala --===============2348825304337160979==--