Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69F01108D9 for ; Tue, 18 Jun 2013 05:51:36 +0000 (UTC) Received: (qmail 49464 invoked by uid 500); 18 Jun 2013 05:51:35 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 49430 invoked by uid 500); 18 Jun 2013 05:51:35 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 49414 invoked by uid 500); 18 Jun 2013 05:51:35 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 49409 invoked by uid 99); 18 Jun 2013 05:51:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 05:51:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 907AB1CCC56; Tue, 18 Jun 2013 05:51:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5010947488602891924==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-1047: tracking in logs using job id From: "Nitin Mehta" To: "Sateesh Chodapuneedi" , "Nitin Mehta" , "Devdeep Singh" Cc: "cloudstack" , "Sanjay Tripathi" Date: Tue, 18 Jun 2013 05:51:21 -0000 Message-ID: <20130618055121.29623.55275@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitin Mehta" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11906/ X-Sender: "Nitin Mehta" References: <20130617114158.32192.997@reviews.apache.org> In-Reply-To: <20130617114158.32192.997@reviews.apache.org> Reply-To: "Nitin Mehta" --===============5010947488602891924== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11906/#review22043 ----------------------------------------------------------- server/src/com/cloud/async/AsyncJobManagerImpl.java it would help if you just keep it as job-id because thats how we log it= in the logs...would be consistent for someone grepping for logs using job-= id server/src/com/cloud/async/AsyncJobManagerImpl.java can this be put in the check above starting with = if (job !=3D null) { server/src/com/cloud/async/AsyncJobManagerImpl.java As said above please keep it as job-id server/src/com/cloud/async/AsyncJobManagerImpl.java what if jobuuid =3D null - Nitin Mehta On June 17, 2013, 11:41 a.m., Sanjay Tripathi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11906/ > ----------------------------------------------------------- > = > (Updated June 17, 2013, 11:41 a.m.) > = > = > Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh Ch= odapuneedi. > = > = > Description > ------- > = > CLOUDSTACK-1047: tracking in logs using job id > = > https://issues.apache.org/jira/browse/CLOUDSTACK-1047 > = > = > This addresses bug CLOUDSTACK-1047. > = > = > Diffs > ----- > = > server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a = > server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb = > = > Diff: https://reviews.apache.org/r/11906/diff/ > = > = > Testing > ------- > = > Tests: > 1. Deploy an Instance. > 2. In the Management server logs, check the async job description, it sho= uld be somthing like: job-[ 22 ] =3D [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1= ] > = > = > Thanks, > = > Sanjay Tripathi > = > --===============5010947488602891924==--