Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F185010847 for ; Tue, 18 Jun 2013 05:22:51 +0000 (UTC) Received: (qmail 10305 invoked by uid 500); 18 Jun 2013 05:22:51 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 10210 invoked by uid 500); 18 Jun 2013 05:22:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 10202 invoked by uid 500); 18 Jun 2013 05:22:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 10196 invoked by uid 99); 18 Jun 2013 05:22:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 05:22:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E722C1CCC56; Tue, 18 Jun 2013 05:22:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2209374808108114561==" MIME-Version: 1.0 Subject: Re: Review Request: remove dead allocations From: "Nitin Mehta" To: "Devdeep Singh" Cc: "cloudstack" , "Dave Brosius" , "Nitin Mehta" Date: Tue, 18 Jun 2013 05:22:38 -0000 Message-ID: <20130618052238.32008.22327@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitin Mehta" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11324/ X-Sender: "Nitin Mehta" References: <20130617134054.32008.72960@reviews.apache.org> In-Reply-To: <20130617134054.32008.72960@reviews.apache.org> Reply-To: "Nitin Mehta" --===============2209374808108114561== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11324/#review22040 ----------------------------------------------------------- api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java Can the result returned be null ? - Nitin Mehta On June 17, 2013, 1:40 p.m., Dave Brosius wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11324/ > ----------------------------------------------------------- > = > (Updated June 17, 2013, 1:40 p.m.) > = > = > Review request for cloudstack and Devdeep Singh. > = > = > Description > ------- > = > code allocates a collection, and then immediately overwrites the referenc= e variable holding that collection. That original collection is just a dead= allocation, and is not needed - patch removes. > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrat= ionCmd.java b2d77b8 = > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java = 69c6980 = > api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRa= ngesCmd.java 75bcce0 = > api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f87= 2c12 = > api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCm= d.java f0fc241 = > = > Diff: https://reviews.apache.org/r/11324/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Dave Brosius > = > --===============2209374808108114561==--