Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58BBF10C75 for ; Mon, 17 Jun 2013 13:41:16 +0000 (UTC) Received: (qmail 94756 invoked by uid 500); 17 Jun 2013 13:41:15 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 94719 invoked by uid 500); 17 Jun 2013 13:41:04 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 94702 invoked by uid 500); 17 Jun 2013 13:41:02 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 94693 invoked by uid 99); 17 Jun 2013 13:41:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jun 2013 13:41:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B59A91CCC25; Mon, 17 Jun 2013 13:40:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8557453939708207458==" MIME-Version: 1.0 Subject: Re: Review Request: remove dead allocations From: "Prasanna Santhanam" To: "Devdeep Singh" Cc: "Prasanna Santhanam" , "Dave Brosius" , "cloudstack" Date: Mon, 17 Jun 2013 13:40:54 -0000 Message-ID: <20130617134054.32008.72960@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasanna Santhanam" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11324/ X-Sender: "Prasanna Santhanam" References: <20130522061144.13727.78351@reviews.apache.org> In-Reply-To: <20130522061144.13727.78351@reviews.apache.org> Reply-To: "Prasanna Santhanam" --===============8557453939708207458== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11324/ ----------------------------------------------------------- (Updated June 17, 2013, 1:40 p.m.) Review request for cloudstack and Devdeep Singh. Changes ------- devdeep (ping) Description ------- code allocates a collection, and then immediately overwrites the reference = variable holding that collection. That original collection is just a dead a= llocation, and is not needed - patch removes. Diffs ----- api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigratio= nCmd.java b2d77b8 = api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69= c6980 = api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRang= esCmd.java 75bcce0 = api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c= 12 = api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.= java f0fc241 = Diff: https://reviews.apache.org/r/11324/diff/ Testing ------- Thanks, Dave Brosius --===============8557453939708207458==--