Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============8873007833153451998=="
MIME-Version: 1.0
Subject: Re: Review Request: Fixed CLOUDSTACK-3004 [script] ssvm_check remove
 the
 duplicate file from consoleproxy and include the script from secondary
 storage folder while packing iso
From: "Nitin Mehta" <nitin.mehta@citrix.com>
To: "Chip Childers" <chipchilders@apache.org>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Nitin Mehta" <nitin.mehta@citrix.com>
Date: Fri, 14 Jun 2013 14:44:03 -0000
Message-ID: <20130614144403.1041.2953@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nitin Mehta" <noreply@reviews.apache.org>
References: <20130614100948.1041.50464@reviews.apache.org>
In-Reply-To: <20130614100948.1041.50464@reviews.apache.org>
Reply-To: "Nitin Mehta" <nitin.mehta@citrix.com>

--===============8873007833153451998==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/#review21905
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On June 14, 2013, 10:09 a.m., Rajesh Battala wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11874/
> -----------------------------------------------------------
> =

> (Updated June 14, 2013, 10:09 a.m.)
> =

> =

> Review request for cloudstack and Chip Childers.
> =

> =

> Description
> -------
> =

> Issue: .There are two ssvm_check scripts(duplicates).
> =

> ./services/console-proxy/server/scripts/ssvm-check.sh
> ./services/secondary-storage/scripts/ssvm-check.sh
> =

> When building the code, these scripts will go to systemvm.zip, systemvm.z=
ip will be packaged into systemvm.iso. =

> =

> systemvm-descriptor.xml will define what all the scripts should package.
> As per the descriptor xml,  the ssvm-check script under console-proxy is =
getting into systemvm.zip.
> =

> I had verified the ssvm-check script with the fix under console-proxy. Th=
e systemvm.zip is getting update properly and making into systemvm.iso.
> And ssvm is getting the right script now.
> =

> Changes made in script under ./services/secondary-storage/scripts/ssvm-ch=
eck.sh is not getting into systemvm.iso
> =

> Fixed:
>     Modified systemvm-descriptor.xml to pick the ssvm-check.sh form ./ser=
vices/secondary-storage/scripts/ssvm-check.sh
>     removed the duplicate file which is creating confusion (./services/co=
nsole-proxy/server/scripts/ssvm-check.sh)
> =

> =

> This addresses bug CLOUDSTACK-3004.
> =

> =

> Diffs
> -----
> =

>   services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 =

>   services/console-proxy/server/systemvm-descriptor.xml e34026b =

> =

> Diff: https://reviews.apache.org/r/11874/diff/
> =

> =

> Testing
> -------
> =

> Tested by generating the systemvm.zip , the ssvm-check file is getting co=
pied into the zip from the ./services/secondary-storage/scripts/ssvm-check.=
sh
> =

> =

> Thanks,
> =

> Rajesh Battala
> =

>


--===============8873007833153451998==--