Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4152F1041D for ; Thu, 13 Jun 2013 22:39:20 +0000 (UTC) Received: (qmail 51818 invoked by uid 500); 13 Jun 2013 22:39:19 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 51770 invoked by uid 500); 13 Jun 2013 22:39:19 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 51759 invoked by uid 500); 13 Jun 2013 22:39:19 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 51750 invoked by uid 99); 13 Jun 2013 22:39:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2013 22:39:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 724F81CCBC3; Thu, 13 Jun 2013 22:39:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0327822606361861180==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-2053: fixed if/else logic to address redundant entires, fixed boto/cloud-init support by adding metadata rewrite rule From: "ASF Subversion and Git Services" To: "Chip Childers" , "Chiradeep Vittal" Cc: "ilya musayev" , "ASF Subversion and Git Services" , "cloudstack" Date: Thu, 13 Jun 2013 22:39:12 -0000 Message-ID: <20130613223912.1041.20419@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11582/ X-Sender: "ASF Subversion and Git Services" References: <20130612235404.1041.36483@reviews.apache.org> In-Reply-To: <20130612235404.1041.36483@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============0327822606361861180== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11582/#review21883 ----------------------------------------------------------- Commit 4612656de86a4a0258852c3fb89724bda6b612b3 in branch refs/heads/4.1 fr= om ilya musayev [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3D4612656 ] CLOUDSTACK-2053: Fixed userdata.sh redundancy and cloud-init support - ASF Subversion and Git Services On June 12, 2013, 11:54 p.m., ilya musayev wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11582/ > ----------------------------------------------------------- > = > (Updated June 12, 2013, 11:54 p.m.) > = > = > Review request for cloudstack, Chip Childers and Chiradeep Vittal. > = > = > Description > ------- > = > Resubmitting for the 3rd time, as review board crashed on my submissions = previously > = > Rewrote the bash if/else check to fix redundant entries > Added RewriteRules to support boto/cloud-init - as per Chiradeep - this w= ould only affect > VMWare deployments, as this userdata.sh script is only used with vmware s= ystem router vms > = > = > This addresses bug CLOUDSTACK-2053. > = > = > Diffs > ----- > = > patches/systemvm/debian/config/root/userdata.sh e5d170b = > = > Diff: https://reviews.apache.org/r/11582/diff/ > = > = > Testing > ------- > = > 4.1 with vSphere > = > = > Thanks, > = > ilya musayev > = > --===============0327822606361861180==--