Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29E3D10A87 for ; Wed, 12 Jun 2013 09:33:59 +0000 (UTC) Received: (qmail 66791 invoked by uid 500); 12 Jun 2013 09:33:56 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 66748 invoked by uid 500); 12 Jun 2013 09:33:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 66612 invoked by uid 500); 12 Jun 2013 09:33:55 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 66573 invoked by uid 99); 12 Jun 2013 09:33:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2013 09:33:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4086E1C9E99; Wed, 12 Jun 2013 09:33:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2668606974812938093==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704 From: "ASF Subversion and Git Services" To: "Abhinandan Prateek" , "Nitin Mehta" Cc: "cloudstack" , "Harikrishna Patnala" , "ASF Subversion and Git Services" Date: Wed, 12 Jun 2013 09:33:47 -0000 Message-ID: <20130612093347.1041.8924@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11780/ X-Sender: "ASF Subversion and Git Services" References: <20130610171933.3558.10760@reviews.apache.org> In-Reply-To: <20130610171933.3558.10760@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============2668606974812938093== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11780/#review21786 ----------------------------------------------------------- Commit a30f9fa64a49acfe7d3ac57f2ef9d890473f48c4 in branch refs/heads/master= from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3Da30f9fa ] Fix for CLOUDSTACK-1704 and CLOUDSTACK-1622 Signed-off-by: Abhinandan Prateek - ASF Subversion and Git Services On June 10, 2013, 5:19 p.m., Harikrishna Patnala wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11780/ > ----------------------------------------------------------- > = > (Updated June 10, 2013, 5:19 p.m.) > = > = > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > = > = > Description > ------- > = > Global parameter "cluster.memory.allocated.capacity.disablethreshold" and= "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluste= r after threshold values. > = > This is due to unhandled sql query when these parameters have null values= in the DB. Fixed by adding that case in the query. > = > = > This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704. > = > = > Diffs > ----- > = > engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a = > = > Diff: https://reviews.apache.org/r/11780/diff/ > = > = > Testing > ------- > = > Tested locally > = > = > Thanks, > = > Harikrishna Patnala > = > --===============2668606974812938093==--