Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CB28A10725 for ; Mon, 10 Jun 2013 13:01:22 +0000 (UTC) Received: (qmail 36680 invoked by uid 500); 10 Jun 2013 13:01:22 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 36287 invoked by uid 500); 10 Jun 2013 13:01:21 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 36261 invoked by uid 500); 10 Jun 2013 13:01:20 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 36256 invoked by uid 99); 10 Jun 2013 13:01:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2013 13:01:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F3EC11CCAD4; Mon, 10 Jun 2013 13:01:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3788075157685796358==" MIME-Version: 1.0 Subject: Re: Review Request: (CLOUDSTACK-2707) use executeBatch instead of persist when Usage Server createNetworkHelperEntry From: "ASF Subversion and Git Services" To: "cloudstack" , "ASF Subversion and Git Services" , "Wei Zhou" Date: Mon, 10 Jun 2013 13:01:12 -0000 Message-ID: <20130610130112.3611.41425@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11461/ X-Sender: "ASF Subversion and Git Services" References: <20130528074207.1348.92626@reviews.apache.org> In-Reply-To: <20130528074207.1348.92626@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============3788075157685796358== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11461/#review21649 ----------------------------------------------------------- Commit 76ce304411259dc4a29e0e070de829b79b46efe2 in branch refs/heads/master= from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3D76ce304 ] CLOUDSTACK-2707: use executeBatch instead of persist in Usage Server - ASF Subversion and Git Services On May 28, 2013, 7:42 a.m., Wei Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11461/ > ----------------------------------------------------------- > = > (Updated May 28, 2013, 7:42 a.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > use executeBatch instead of persist can reduce the time spent on insertin= g records into database. > = > = > This addresses bug CLOUDSTACK-2707. > = > = > Diffs > ----- > = > engine/schema/src/com/cloud/usage/dao/UsageNetworkDao.java 0f7c771 = > engine/schema/src/com/cloud/usage/dao/UsageNetworkDaoImpl.java d64fd80 = > usage/src/com/cloud/usage/UsageManagerImpl.java 16fe67b = > = > Diff: https://reviews.apache.org/r/11461/diff/ > = > = > Testing > ------- > = > Testing ok. > = > = > Thanks, > = > Wei Zhou > = > --===============3788075157685796358==--