Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 154BC10EAD for ; Fri, 7 Jun 2013 11:09:32 +0000 (UTC) Received: (qmail 86163 invoked by uid 500); 7 Jun 2013 11:09:31 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 86121 invoked by uid 500); 7 Jun 2013 11:09:30 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 86113 invoked by uid 500); 7 Jun 2013 11:09:29 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 86107 invoked by uid 99); 7 Jun 2013 11:09:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jun 2013 11:09:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 762281CC9E8; Fri, 7 Jun 2013 11:09:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5039330587789583639==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources From: "Devdeep Singh" To: "Nitin Mehta" , "Devdeep Singh" Cc: "cloudstack" , "Sanjay Tripathi" Date: Fri, 07 Jun 2013 11:09:22 -0000 Message-ID: <20130607110922.22886.28131@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Devdeep Singh" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11298/ X-Sender: "Devdeep Singh" References: <20130521081327.13727.22596@reviews.apache.org> In-Reply-To: <20130521081327.13727.22596@reviews.apache.org> Reply-To: "Devdeep Singh" --===============5039330587789583639== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11298/#review21568 ----------------------------------------------------------- engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServic= eImpl.java Why not get an updated volumeObject before calling processEvent (from t= he volFactory like you are doing in the callback)? That way the change is n= ot required in the callback. - Devdeep Singh On May 21, 2013, 8:13 a.m., Sanjay Tripathi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11298/ > ----------------------------------------------------------- > = > (Updated May 21, 2013, 8:13 a.m.) > = > = > Review request for cloudstack, Devdeep Singh and Nitin Mehta. > = > = > Description > ------- > = > CLOUDSTACK-2286: Volume created from snapshot state is in allocated state= instead of Ready state which is letting Primary storage not to increment t= he resources > = > = > This addresses bug CLOUDSTACK-2286. > = > = > Diffs > ----- > = > engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeSe= rviceImpl.java 7fdf6bb = > = > Diff: https://reviews.apache.org/r/11298/diff/ > = > = > Testing > ------- > = > Verified on my local CloudStack setup. > = > = > Thanks, > = > Sanjay Tripathi > = > --===============5039330587789583639==--