cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: easy bug to fix for new comer
Date Fri, 21 Jun 2013 09:12:34 GMT
I submitted a biggy. please review this and consider whether pep8 is
beating the purpose of formatting. Espacially line length of 80 seems not
what you want. You'll want your terminals show more character then that in
this century.


On Fri, Jun 21, 2013 at 10:07 AM, Prasanna Santhanam <tsp@apache.org> wrote:

> Yup - please skip that too.
>
> On Fri, Jun 21, 2013 at 09:56:47AM +0200, Daan Hoogland wrote:
> > how about sandbox? It doesn't sound like really long term strategic code
> > either.
> >
> >
> > On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam <tsp@apache.org>
> wrote:
> >
> > > One other thing: You can skip pep8-ing the integration module since
> > > that will be deprecated in the future. There's a lot of classes in
> > > there so it'll save you time.
> > >
> > > On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
> > > > Daan,
> > > >
> > > > Your patches applied cleanly and have been committed to master.
> > > > Please mark the review as submitted
> > > >
> > > > In your next patches try to use the bug id in at the start of the
> > > comment, that way the commit will automatically show up in JIRA and
> review
> > > board?magic.
> > > >
> > > > do something like that:
> > > >
> > > > git commit -m "CLOUDSTACK-3096: blah blah blah?."
> > > >
> > > > You can also send everything as a single commit?just edit the files,
> > > stage them, git add?.and do a single commit.
> > > >
> > > > thanks a lot?I told you this was an easy one :)
> > > >
> > > > -sebastien
> > > >
> > > > On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <runseb@gmail.com>
> > > wrote:
> > > >
> > > --
> > > Prasanna.,
> > >
> > > ------------------------
> > > Powered by BigRock.com
> > >
> > >
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message