cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Saksham Srivastava <saksham.srivast...@citrix.com>
Subject RE: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades
Date Wed, 05 Jun 2013 09:57:04 GMT
In  4.1 during encryption the category was made 'Secure'.
So this will check if encryption is actually needed and will prevent encrypting twice. Unencrypted
value will have category as 'Hidden'.
I will wait for 4.1.1 upgrade path and add the fix then.
 
Thanks,
Saksham

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com] 
Sent: Wednesday, June 05, 2013 12:40 AM
To: dev@cloudstack.apache.org; Chiradeep Vittal
Cc: Kishan Kavala; Saksham Srivastava; cloudstack
Subject: Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

Also, we already released 4.1.0.  If this is needed, how should it be correctly done for a
4.1.1 release?


On Tue, Jun 04, 2013 at 05:03:49PM +0000, Chiradeep Vittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/#review21422
> -----------------------------------------------------------
> 
> 
> 
> engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java
> <https://reviews.apache.org/r/11627/#comment44357>
> 
>     The logic is not clear. Can you add a few comments and logs as to WHY the system
vm password is being updated?
> 
> 
> - Chiradeep Vittal
> 
> 
> On June 4, 2013, 12:53 p.m., Saksham Srivastava wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11627/
> > -----------------------------------------------------------
> > 
> > (Updated June 4, 2013, 12:53 p.m.)
> > 
> > 
> > Review request for cloudstack and Kishan Kavala.
> > 
> > 
> > Description
> > -------
> > 
> > Encrypt system.vm.password and make the configuration as Secure.
> > 
> > 
> > This addresses bug CLOUDSTACK-1012.
> > 
> > 
> > Diffs
> > -----
> > 
> >   engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9
> > 
> > Diff: https://reviews.apache.org/r/11627/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Tested on local setup.
> > Build successful.
> > 
> > 
> > Thanks,
> > 
> > Saksham Srivastava
> > 
> >
> 

Mime
View raw message