cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <...@apache.org>
Subject Re: Review Request 12200: Fixed issues while adding DC to zone in VM ware
Date Sun, 30 Jun 2013 08:00:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12200/#review22582
-----------------------------------------------------------


I think you were working on an old HEAD which is why most of the pep8 and storage related
changes were removed. Please resubmit after pulling in latest

Also, don't forget to run a pep8 check on the file
$ pip install pep8
$ pep8 deployDataCenter.py

You can check for tab issues using tabnanny
$ python -m tabnanny tools


tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46298>

    Retain this as the new style class inheriting from `object`.



tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46299>

    These are required for adding object store and cache storage. Were these removed intentionally?



tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/12200/#comment46300>

    These are required for adding object store and cache storage. Were these removed intentionally?


- Prasanna Santhanam


On June 30, 2013, 7:29 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12200/
> -----------------------------------------------------------
> 
> (Updated June 30, 2013, 7:29 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed issues  while adding DC to zone in VM ware, 
> 
> Also script modified to skip adding host in vmware.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py 961718a 
> 
> Diff: https://reviews.apache.org/r/12200/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message