cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request 11953: Remove code that does nothing but allocate a bunch of objects
Date Sat, 29 Jun 2013 14:56:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/#review22566
-----------------------------------------------------------


Looks like the whole point is to calculate the poolId and the DataCenterDeployment constructor
does take a poolId argument, but instead a null is passed. Just wondering if the original
intention here was to pass the poolId over rather than having null there.

But anyway, the temporary object reservation would not be necessary even then, the code could
iterate over the keySet() rather than on its copy.

- Laszlo Hornyak


On June 29, 2013, 2:35 a.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11953/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 2:35 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> remove code that may have been used for something in the past, but now does nothing but
allocate memory temporarily.
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
38ed7e6 
> 
> Diff: https://reviews.apache.org/r/11953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message