cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Review Request 12180: Fix NPE when adding invalid primary datastore
Date Fri, 28 Jun 2013 21:39:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/
-----------------------------------------------------------

Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-3110


Repository: cloudstack-git


Description
-------

Fixing an NPE when an attempt is made to add a primary datastore by providing an unreachable/nonexistent
datastore/host.


Diffs
-----

  engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java b92f92f

  engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
06b54e0 

Diff: https://reviews.apache.org/r/12180/diff/


Testing
-------

With fix in place, an attempt to add an invalid primary datastore will fail with a GUI error
dialog instead of failing silently with an NPE in the mgmt server log.


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message