cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Donal Lafferty" <donal.laffe...@citrix.com>
Subject Re: Review Request 12106: Removed Dead Code from Management Server Hyper-V 2012 Support
Date Thu, 27 Jun 2013 08:56:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12106/
-----------------------------------------------------------

(Updated June 27, 2013, 8:56 a.m.)


Review request for cloudstack, Alex Huang, Chip Childers, and edison su.


Changes
-------

Move Review requests 12105, 12103, 12085, because this submission duplicates the diffs in
those review requests.


Summary (updated)
-----------------

Removed Dead Code from Management Server Hyper-V 2012 Support


Repository: cloudstack-git


Description (updated)
-------

Update ImageFormat enum to include VHDX format introduced with Hyper-V Server 2012.
Remove existing Hyper-V plugin, because it does not work and is dead code.
Remove references to existing Hyper-V plugin from config files.
Remove Hypervisor.HypervisorType.Hyperv special cases from manager code that are unused or
unsupported.
Specifically, there is no CIFS secondary storage class "CifsSecondaryStorageResource".  Also,
the Hyper-V plugin's ServerResource is contacted by the management server and not the other
way around.
Add Hyperv-V support to ListHypervisorsCmd API call


Diffs
-----

  agent/src/com/cloud/agent/VmmAgentShell.java 190d1168284243f9e860677a03311da9db31c745 
  api/src/com/cloud/storage/Storage.java 9a50ffa786c9a1b516baa7b8bce04de7d3c7b2bc 
  client/tomcatconf/applicationContext.xml.in ac1f3e46fdb43b4a5e38f9f2b3c498a2c258a0aa 
  core/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java 725f0cc1ae214447f20f5cd51c40e7e9128f0506

  engine/storage/integration-test/test/resource/component.xml 5ba87e8ebe9a682b320c60caf0e0057d2eb92027

  plugins/network-elements/dns-notifier/resources/components-example.xml 717c5e063fe0271eeb1143215a493c6342c5811e

  server/src/com/cloud/configuration/Config.java ba508495c350714fff90da0923b046783d42b1c3

  server/src/com/cloud/hypervisor/guru/HypervGuru.java 630080e21cbb6a501d67bda41179feb278b3d79c

  server/src/com/cloud/hypervisor/hyperv/HypervServerDiscoverer.java 06658b7f3e2ea5e80edf012dcaf29d980758084d

  server/src/com/cloud/resource/ResourceManagerImpl.java fe91cb337d0f5901012ca45e131d9cb2f7c54cf2

  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 954c7e970f02e7ba0eae6e8e1616d9a08c9168b0


Diff: https://reviews.apache.org/r/12106/diff/


Testing
-------

Compiled using mvn clean install, used in integration test on cshv3 branch from github mirror.


Thanks,

Donal Lafferty


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message