cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters
Date Mon, 24 Jun 2013 06:49:29 GMT


> On June 20, 2013, 10:12 a.m., Nitin Mehta wrote:
> > Ship It!

Please rebase

Nitins-MacBook-Air:cloudstack nitinmehta$ git apply ../0001-CLOUDSTACK-2916-admin-is-not-able-to-login-through-U.patch

error: patch failed: server/src/com/cloud/configuration/ConfigurationManagerImpl.java:336
error: server/src/com/cloud/configuration/ConfigurationManagerImpl.java: patch does not apply


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
-----------------------------------------------------------


On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 9:42 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold"
to some string 
> CLOUDSTACK-2457:  No check for input values,special character,-ive values can be assigne
to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
> 
> Added validation for float values and checking limit for weight based parameters by creating
a set of parameters.
> 
> 
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340 
> 
> Diff: https://reviews.apache.org/r/11989/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message