cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chipchild...@apache.org>
Subject Re: fixPath (was: committer wanted for review)
Date Fri, 21 Jun 2013 13:31:02 GMT
On Fri, Jun 21, 2013 at 09:38:56AM +0200, Daan Hoogland wrote:
> On Fri, Jun 21, 2013 at 6:18 AM, Prasanna Santhanam <tsp@apache.org> wrote:
> 
> > > <rant>To my mind, we overuse String throughout the codebase when we
> > > should either be using richer types provided by the Java runtime
> > > (e.g. java.net.URI) or defining custom value objects.  In addition
> > > to better levering the type checking of the compiler and potentially
> > > exploiting polymorphism, rich value objects allow business rules to
> > > be neatly encapsulated -- DRYing out the code base and allowing them
> > > to reliably unit tested.</rant>
> >
> > +1 to the rant. String is over-(ab)-used. Sometimes even to do XML.
> > Happy to help moving all that if there's a plan you guys work out
> > Sunday. Please bring it back to the lists.
> 
> 
> John and Prasanna,
> 
> You are being an architect, excuse my Dutch. Of course you are right, for
> CloudStack 5.0. In the meantime I have real users with real customers that
> don't care if I use File or my own custom Directory object or
> String(Buffer).
> 
> So +1 for your sunday proposal but 'duhuh' for your rant.  I still need to
> backport my patch to 4.1 and 4.2 of CLoudStack, with or without the
> apache.org bit.
> 
> Had to get that of my chest.
> 
> regards,
> Daan

Let's all remember to keep discussions focused on the code itself
please, and not be personal about things.

Mime
View raw message