cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Review Request: CLOUDSTACK-2304 [ZWPS]NPE while migrating volume from one zone wide primary to another
Date Fri, 21 Jun 2013 12:32:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12025/
-----------------------------------------------------------

Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and Ram Ganesh.


Description
-------

Issue : while migrating the volume from one ZWPS to another ZWPS then NPE is having which
is failing the migration of volume
Fixed: The issue is, if the volume is in ZWPS then the volume object won't be having podid.

       while volume migration, ZWPS specific volume cases are not handled.
        Fixed the issues by adding a new constructor in VolumeVO and taken care in VolumeServiceImpl
to handle ZWPS volume while migration.


This addresses bug CLOUDSTACK-2304.


Diffs
-----

  engine/schema/src/com/cloud/storage/VolumeVO.java 02c09a2 
  engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 1d36f93


Diff: https://reviews.apache.org/r/12025/diff/


Testing
-------

Setup:
Create a KVM cluster and add zwps to the primary storage. ZWPS got mounted on KVM. Created
instances in KVM.
1. Create a Volume and attach the volume to the running VM. volume got successfully attached
to the VM. 
2. Detach the Volume and then try to Migrate the Volume to another ZWPS added to the ZONE.
volume got migrated successfully to another ZWPS.
   Observed Volume got copied to the new ZWPS and then the old volume is deleted.
   Verified db, the volume uuid got updated and necessary fields.

Addition Testing:
================ 
Created Xenserver cluster add cluster scope storage.
1. create a volume and attach the instance running in Xenserver. Success.
2. detach the volume and try to migrate the volume to another cluster scope storage. Volume
got successfully migrate to another storage. 
   Observed Volume got copied to the new PS and then the old volume is deleted.
   Verified db, the volume uuid got updated and necessary fields.


Thanks,

Rajesh Battala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message