cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.
Date Thu, 20 Jun 2013 05:32:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22149
-----------------------------------------------------------


Commit e420c3be8c597da6abf8915a99b0e3f860fda034 in branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e420c3b ]

CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order


- ASF Subversion and Git Services


On June 19, 2013, 11:37 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11708/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> When multiple vlan ranges are added to a physical networks the vlan ranges displayed
in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges
were added,Instead if they are displayed in the ascending order range this would make it easy
for the end user.
> 
> 
> This addresses bug CLOUDSTACK-2167.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 
> 
> Diff: https://reviews.apache.org/r/11708/diff/
> 
> 
> Testing
> -------
> 
> The response of list api is now enhanced:
> <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
> <count>1</count>
> <physicalnetwork>
> <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
> <name>Physical Network 1</name>
> <broadcastdomainrange>ZONE</broadcastdomainrange>
> <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
> <state>Enabled</state>
> <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
> <isolationmethods>VLAN</isolationmethods>
> </physicalnetwork>
> </listphysicalnetworksresponse>
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message