cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges
Date Thu, 20 Jun 2013 00:21:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11026/#review22139
-----------------------------------------------------------


Commit b3fb4851ee204b1be514e389c66fd6e08d4b7fa4 in branch refs/heads/master from Sheng Yang
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b3fb485 ]

Fix regression of return Userdata provider when caller asked for DHCP

It's introduced by:

commit 052c24c4d1c881f791b804dbb9c2fc083af7da36
Author: Bharat Kumar <bharat.kumar@citrix.com>
Date:   Mon May 13 17:02:27 2013 +0530

    CLOUDSTACK-702: Multiple ip ranges in different subnets.

This commit get userdata provider when caller asked for dhcp provider, thus
result in trouble e.g.

ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-11:job-10) Unexpected
exception while executing
org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd
java.lang.ClassCastException:
com.cloud.baremetal.networkservice.BaremetalUserdataElement_EnhancerByCloudStack_5dee69d2
cannot be cast to com.cloud.network.element.DhcpServiceProvider
        at
com.cloud.network.NetworkManagerImpl.getDhcpServiceProvider(NetworkManagerImpl.java:3309)
...


- ASF Subversion and Git Services


On May 9, 2013, 1:23 p.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11026/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 1:23 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-702: Tests for Multiple IP Ranges
> 1. Add ip range super set to existing CIDR
> 2. Add ip range subset to existing CIDR
> 
> 
> This addresses bug CLOUDSTACK-702.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_multiple_ip_ranges.py 7e9eeb1 
> 
> Diff: https://reviews.apache.org/r/11026/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message