cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "edison su" <edison...@citrix.com>
Subject Re: Review Request: FileUtil simplified
Date Wed, 19 Jun 2013 21:26:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11980/#review22133
-----------------------------------------------------------



plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
<https://reviews.apache.org/r/11980/#comment45535>

    unit test will fail when compiling the code on Mac/Windows. How about add something like:
http://www.thekua.com/atwork/2008/09/running-tests-on-a-specific-os-under-junit4/


- edison su


On June 19, 2013, 9:03 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11980/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 9:03 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> - writeToFile removed since no references to it
> - readFileAsString replaced with FileUtils.readFileToString
> - minor code duplication removed in dependent method getNicStats
> - unit test added
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
7d90f6a 
>   plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
c82c31f 
>   utils/src/com/cloud/utils/FileUtil.java 74f4088 
> 
> Diff: https://reviews.apache.org/r/11980/diff/
> 
> 
> Testing
> -------
> 
> test included
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message