cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
Date Wed, 19 Jun 2013 05:15:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/#review22108
-----------------------------------------------------------


Try to use final String instead of literals for better maintainability.

- Abhinandan Prateek


On June 18, 2013, 7:05 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11910/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 7:05 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling
of vm 
> 
> CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools
in the template
> This should also take care of updation of VM after XS tools are installed in the vm and
set memory values accordingly to support dynamic scaling after stop start of VM
> 
> 
> This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b 
>   api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 
>   api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 
>   api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 
>   api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2

>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 
>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a 
>   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a 
>   core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc 
>   engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb

>   plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
5e8283a 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
8e37809 
>   server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d 
>   server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f 
>   server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 
>   server/src/com/cloud/storage/TemplateProfile.java 0b55f1f 
>   server/src/com/cloud/template/TemplateAdapter.java 9a2d877 
>   server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e 
>   setup/db/db/schema-410to420.sql 272fc42 
> 
> Diff: https://reviews.apache.org/r/11910/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message