cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request: remove dead allocations
Date Tue, 18 Jun 2013 05:22:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/#review22040
-----------------------------------------------------------



api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java
<https://reviews.apache.org/r/11324/#comment45376>

    Can the result returned be null ?


- Nitin Mehta


On June 17, 2013, 1:40 p.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11324/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 1:40 p.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> code allocates a collection, and then immediately overwrites the reference variable holding
that collection. That original collection is just a dead allocation, and is not needed - patch
removes.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java
b2d77b8 
>   api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980 
>   api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java
75bcce0 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241

> 
> Diff: https://reviews.apache.org/r/11324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message