cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Duffy" <...@ianduffy.ie>
Subject Re: Review Request: Fix CLOUDSTACK-2168
Date Mon, 17 Jun 2013 14:00:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/
-----------------------------------------------------------

(Updated June 17, 2013, 2 p.m.)


Review request for cloudstack and Sebastien Goasguen.


Description
-------

CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.

This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.

I have modified the API command to return a "list" like format, but since cloudstack only
currently supports authentication against one ldap server it will only return 1 configuration.

Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add
support for multiple ldap servers will have to expand on this output. 


This addresses bug CLOUDSTACK-2168.


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84 

Diff: https://reviews.apache.org/r/11907/diff/


Testing
-------

Build the code with the changes, confirmed the API still returned the expected results.
Confirmed that the UI showed the configuration.


Thanks,

Ian Duffy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message