cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request: Change getListAll() within the LDAPConfigCmd.java file to return a boolean instead of a string.
Date Mon, 17 Jun 2013 04:52:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11863/#review21968
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On June 13, 2013, 2:15 p.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11863/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 2:15 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Change getListAll() within the LDAPConfigCmd.java file to return a boolean instead of
a string. It was only being used as true or false and didn't make sense to have it as a string.
> 
> Fixed a slight typo on the exception thrown when no hostname, searchbase or queryfilter
is given.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2976de4 
> 
> Diff: https://reviews.apache.org/r/11863/diff/
> 
> 
> Testing
> -------
> 
> Built it and confirmed the command still worked as expected.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message