cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Duffy" <...@ianduffy.ie>
Subject Review Request: Change getListAll() within the LDAPConfigCmd.java file to return a boolean instead of a string.
Date Thu, 13 Jun 2013 14:15:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11863/
-----------------------------------------------------------

Review request for cloudstack.


Summary (updated)
-----------------

Change getListAll() within the LDAPConfigCmd.java file to return a boolean instead of a string.


Description (updated)
-------

Change getListAll() within the LDAPConfigCmd.java file to return a boolean instead of a string.
It was only being used as true or false and didn't make sense to have it as a string.

Fixed a slight typo on the exception thrown when no hostname, searchbase or queryfilter is
given.


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2976de4 

Diff: https://reviews.apache.org/r/11863/diff/


Testing (updated)
-------

Built it and confirmed the command still worked as expected.


Thanks,

Ian Duffy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message