cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.
Date Fri, 07 Jun 2013 11:40:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10005/#review21572
-----------------------------------------------------------


Commit 5dc7387d3b6b1abd841abc92e3c76a3894213d82 in branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5dc7387 ]

CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is
not same but their start ip and end ip are same.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>


- ASF Subversion and Git Services


On June 5, 2013, 11:39 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10005/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> In cases where the start ip and end ip of guest vm cidr and network cidr are same, even
when the cidrs appear to be different,the reservation procedure should not go through and
user should get a message mentioning that.
> Added extra check for the same with proper alert message.
> 
> 
> This addresses bug CLOUDSTACK-1647.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 2bf9f40 
>   utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 
>   utils/test/com/cloud/utils/net/NetUtilsTest.java 16d3402 
> 
> Diff: https://reviews.apache.org/r/10005/diff/
> 
> 
> Testing
> -------
> 
> CIDR : 10.0.144.0/20, Network CIDR : null, guestVmCidr : 10.0.151.0/20 => Reservation
is not applied.
> CIDR : 10.0.144.0/21, Network CIDR : 10.0.144.0/20, guestVmCidr : 10.0.151.0/20 =>
Existing Reservation is not affected.
> Added UnitTest testIsSameIpRange()
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message