cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources
Date Fri, 07 Jun 2013 11:09:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11298/#review21568
-----------------------------------------------------------



engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
<https://reviews.apache.org/r/11298/#comment44616>

    Why not get an updated volumeObject before calling processEvent (from the volFactory like
you are doing in the callback)? That way the change is not required in the callback.


- Devdeep Singh


On May 21, 2013, 8:13 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11298/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 8:13 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of
Ready state which is letting Primary storage not to increment the resources
> 
> 
> This addresses bug CLOUDSTACK-2286.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
7fdf6bb 
> 
> Diff: https://reviews.apache.org/r/11298/diff/
> 
> 
> Testing
> -------
> 
> Verified on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message