Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB23FF125 for ; Thu, 9 May 2013 11:25:24 +0000 (UTC) Received: (qmail 65506 invoked by uid 500); 9 May 2013 11:25:24 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 65254 invoked by uid 500); 9 May 2013 11:25:23 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 65225 invoked by uid 99); 9 May 2013 11:25:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2013 11:25:22 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of dhkakadia@gmail.com designates 209.85.216.53 as permitted sender) Received: from [209.85.216.53] (HELO mail-qa0-f53.google.com) (209.85.216.53) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2013 11:25:16 +0000 Received: by mail-qa0-f53.google.com with SMTP id f11so1590534qae.19 for ; Thu, 09 May 2013 04:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=rL/5dWwQ43lVr2r4u/M3C2ELcm//+mojixMq8f80X04=; b=jTr+2h3Qvm5lNo0XnJaC9sBOEDNDJTTEGpj2OAc9+ewYJQxdi5e6Ml8QA04AC0Com6 CxGPmbUusaBVNvFtm1fq/aenNVa+v/tyv1D/sTjlaU4Ogy9SQ4ns7g3pfzDHyKIKT4lV BNdYYEQqk+Y0uGhW1EgPykMCYhHQPdVue+KCuI/8W9kmdT2qfKpihgOQR289BUHheznx S8CblrfiE9h2XBjNrig1WrmMvTJZukboosvr+qKKy3RwCTGWbfFPWaTITi2t5YISlzpI 5Uzc5piPNhLSXsMA0SPwiBnRaxNVHkhlRLjgTuaK+pNPV5ntXJpCQvxAXgEb8492OUk/ 2HfQ== X-Received: by 10.229.69.34 with SMTP id x34mr2618461qci.75.1368098696050; Thu, 09 May 2013 04:24:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.49.52.98 with HTTP; Thu, 9 May 2013 04:24:35 -0700 (PDT) In-Reply-To: References: <20130507193801.GE10900@USLT-205755.sungardas.corp> <20130508133052.GI33720@USLT-205755.sungardas.corp> <244783D9-4F29-4C41-BBCB-21C82C218A00@gmail.com> From: Dharmesh Kakadia Date: Thu, 9 May 2013 16:54:35 +0530 Message-ID: Subject: Re: Suggestion needed for CLOUDSTACK-212 To: dev Content-Type: multipart/alternative; boundary=00032557fa1ecbc55704dc474cc0 X-Virus-Checked: Checked by ClamAV on apache.org --00032557fa1ecbc55704dc474cc0 Content-Type: text/plain; charset=ISO-8859-1 I have finished the refactoring (ran into eclipse refactoring bugs). I am now trying to test. But I realized that it will be good to have tool/script that does most of this refactoring rather than using eclipse. Anyone knows any such tool/script ? Otherwise I plan to make one. Thanks, Dharmesh On Wed, May 8, 2013 at 9:08 PM, Dharmesh Kakadia wrote: > I have started refactoring !! I am planning to finish refactoring by > tomorrow. I will then need help and guidance in doing testing,branching > etc. Let's try this out !! > > Thanks, > Dharmesh > > > On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen wrote: > >> >> On May 8, 2013, at 9:30 AM, Chip Childers >> wrote: >> >> > Dharmesh, >> > >> > I'd also suggest that you actually plan on submitting this after the 4.2 >> > feature freeze, to be included in 4.3. This is the type of change that >> > has bitten us with almost every release... and doing it close to the >> > end of the merge window may not be a good idea. Our general preference >> > is to do these types of changes in master right *after* the latest >> > feature release has it's branch cut. >> > >> > -chip >> >> To add to that, feature freeze for 4.2 is scheduled to be 5/31. >> >> We could have your code in a feature branch before that, and merge it >> early june. It would then be included in 4.3 >> >> >> >> > >> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote: >> >> ok. I will go with that. >> >> >> >> Thanks, >> >> Dharmesh >> >> >> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers < >> chip.childers@sungard.com>wrote: >> >> >> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote: >> >>>> Hi, >> >>>> >> >>>> I am trying to move java package structure from com.cloud to >> org.apache ( >> >>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am >> thinking of >> >>>> doing it the following way (Totally newbie), needed feedback on that. >> >>>> >> >>>> 1. grep "com.cloud" on the entire repo. >> >>>> 2. update all package declarations using eclipse. >> >>>> 3. Update scripts etc found in 1 manually. >> >>>> >> >>>> Will it be a good way to do it ? Any better suggestion ? >> >>>> >> >>>> Thanks, >> >>>> Dharmesh >> >>> >> >>> That seems like a reasonable approach. We will probably want to >> create >> >>> a branch when you submit a patch for this, and apply it there... just >> >>> to spend some time ensuring that the changes work. >> >>> >> >>> -chip >> >>> >> >> > --00032557fa1ecbc55704dc474cc0--