Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC71FF6F2 for ; Fri, 3 May 2013 21:29:32 +0000 (UTC) Received: (qmail 85512 invoked by uid 500); 3 May 2013 21:29:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 85456 invoked by uid 500); 3 May 2013 21:29:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 85448 invoked by uid 99); 3 May 2013 21:29:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2013 21:29:32 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of shadowsor@gmail.com designates 209.85.220.172 as permitted sender) Received: from [209.85.220.172] (HELO mail-vc0-f172.google.com) (209.85.220.172) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2013 21:29:25 +0000 Received: by mail-vc0-f172.google.com with SMTP id hx10so1816131vcb.31 for ; Fri, 03 May 2013 14:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=rfG0XE8kq3njxtc0vT+zQEDiGimyhJ+N73Xzhlxe+AM=; b=SroGwXAWzYllGLj6XW8VXIIVg2748cqmgw7syDM0uecpNcxGFVpUeI7g/Vnkr18OY3 MQeBZ/LYJk6g1i+HcSIA+A716LxEOUl53RxQ9YYz8/GcCuqoPm/nUgaywsy3dtTDOpA3 efnx+cMDiphMhYrTkq9YV7cUACnJF1fXrkcT7+uaZVRiok6maybqp5ODUdsPMkxMcshr 8/mAwH3ZxRo3cqp7CyAcgSv4bf6HPU7GSIERhobDH6BTzqolFHxHYVzy2qIODSZfZ1Ti Tp2Z/57cuX11j9nvCic+XSNaDvhkFYW6wHafu9ckLQUejr2DciJiOg2W1mWszEEXjZQa Zc4w== MIME-Version: 1.0 X-Received: by 10.58.144.170 with SMTP id sn10mr4192689veb.7.1367616544449; Fri, 03 May 2013 14:29:04 -0700 (PDT) Received: by 10.52.103.106 with HTTP; Fri, 3 May 2013 14:29:04 -0700 (PDT) In-Reply-To: <20130503210522.17260.82580@reviews.apache.org> References: <20130501164712.17260.73676@reviews.apache.org> <20130503210522.17260.82580@reviews.apache.org> Date: Fri, 3 May 2013 15:29:04 -0600 Message-ID: Subject: Re: Review Request: Remove filterwin2k from virtual router default config From: Marcus Sorensen To: "dev@cloudstack.apache.org" , Dennis Lawler Cc: Frank Zhang , Chiradeep Vittal , cloudstack Content-Type: multipart/alternative; boundary=047d7b672198522d8d04dbd70a08 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b672198522d8d04dbd70a08 Content-Type: text/plain; charset=ISO-8859-1 Make sure you put in a request for it to be pulled into 4.1 (for CLOUDSTACK-282), or provide a second patch if it doesn't cherry-pick cleanly out of master! On Fri, May 3, 2013 at 3:05 PM, Dennis Lawler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10843/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 9:05 p.m.) > > > Review request for cloudstack and Frank Zhang. > > > Changes > ------- > > Rebased patch against master! > > > Description > ------- > > Commenting out filterwin2k. > > Should this be pushed back as a patch for older branches as well? > > > This addresses bugs CLOUDSTACK-2224 and CLOUDSTACK-282. > > > Diffs (updated) > ----- > > patches/systemvm/debian/config/etc/dnsmasq.conf.tmpl 7d656cb > patches/systemvm/debian/config/etc/vpcdnsmasq.conf 3717fc8 > > Diff: https://reviews.apache.org/r/10843/diff/ > > > Testing > ------- > > Verified in local environment that SRV records are accessible, enabling > Windows KMS services. > > > Thanks, > > Dennis Lawler > > --047d7b672198522d8d04dbd70a08--