Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32A09F85F for ; Wed, 8 May 2013 00:29:36 +0000 (UTC) Received: (qmail 28560 invoked by uid 500); 8 May 2013 00:29:35 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 28442 invoked by uid 500); 8 May 2013 00:29:35 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 28431 invoked by uid 99); 8 May 2013 00:29:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2013 00:29:35 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of seizadi@infoblox.com designates 205.234.19.214 as permitted sender) Received: from [205.234.19.214] (HELO mx2.infoblox.com) (205.234.19.214) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2013 00:29:28 +0000 X-ASG-Debug-ID: 1367972943-0640d7440d12c50001-AbHazq Received: from x2008hub1.infoblox.com (x2008hub1.infoblox.com [205.234.19.248]) by mx2.infoblox.com with ESMTP id Hyidnh4YF9AjNTSC for ; Tue, 07 May 2013 17:29:03 -0700 (PDT) X-Barracuda-Envelope-From: seizadi@infoblox.com X-Barracuda-Apparent-Source-IP: 205.234.19.248 Received: from X2008MB1.infoblox.com ([fe80::cc0b:9da5:6863:8541]) by x2008hub1.infoblox.com ([fe80::a3:8989:52dd:1d09%10]) with mapi id 14.02.0298.004; Tue, 7 May 2013 17:29:04 -0700 From: Soheil Eizadi To: "dev@cloudstack.apache.org" Subject: DeleteNiciraNvpDeviceCmd.java Thread-Topic: DeleteNiciraNvpDeviceCmd.java X-ASG-Orig-Subj: DeleteNiciraNvpDeviceCmd.java Thread-Index: AQHOS4LoamQM5X2eJU+c30BqutbUyw== Date: Wed, 8 May 2013 00:29:02 +0000 Message-ID: <6717EC2E5A665A40A5AF626D7D4FA906BECEB5@x2008mb1.infoblox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.102.28.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Barracuda-Connect: x2008hub1.infoblox.com[205.234.19.248] X-Barracuda-Start-Time: 1367972943 X-Barracuda-URL: http://205.234.19.214:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at infoblox.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.130310 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Checked: Checked by ClamAV on apache.org I was reviewing the NiciraNvp code, it is a very good model of External Net= work Device in CloudStack. I noted that in DeleteNiciraNvpDeviceCmd.java, t= he function:=0A= =0A= @Override=0A= public String getEventType() {=0A= return EventTypes.EVENT_EXTERNAL_LB_DEVICE_DELETE;=0A= }=0A= =0A= should be returning EVENT_EXTERNAL_NVP_CONTROLLER_DELETE=0A= =0A= probably minor, but wanted to note here.=0A= -Soheil=0A=