Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3AB4A9E6A for ; Tue, 28 May 2013 13:07:46 +0000 (UTC) Received: (qmail 60572 invoked by uid 500); 28 May 2013 13:07:45 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 60323 invoked by uid 500); 28 May 2013 13:07:45 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 60299 invoked by uid 500); 28 May 2013 13:07:45 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 60289 invoked by uid 99); 28 May 2013 13:07:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 May 2013 13:07:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B8BF1CB8BE; Tue, 28 May 2013 13:07:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1089130823425797047==" MIME-Version: 1.0 Subject: Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host From: "Saksham Srivastava" To: "Prachi Damle" , "Devdeep Singh" Cc: "Saksham Srivastava" , "cloudstack" Date: Tue, 28 May 2013 13:07:39 -0000 Message-ID: <20130528130739.1348.16727@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Saksham Srivastava" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11380/ X-Sender: "Saksham Srivastava" References: <20130528014759.1348.58032@reviews.apache.org> In-Reply-To: <20130528014759.1348.58032@reviews.apache.org> Reply-To: "Saksham Srivastava" --===============1089130823425797047== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/ ----------------------------------------------------------- (Updated May 28, 2013, 1:07 p.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Changes ------- Updated Patch. Description ------- Patch 2 for https://reviews.apache.org/r/11379/ Created for files server/src/com/cloud/deploy/DeploymentPlanningManagerImpl= .java, server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, ser= ver/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java This addresses bug CLOUDSTACK-681. Diffs (updated) ----- server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 = server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 = server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 484b0= 44 = Diff: https://reviews.apache.org/r/11380/diff/ Testing ------- Unittest: For the new APIs and Service, added unit tests under : plugins/de= dicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest= .java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if v= m is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava --===============1089130823425797047==--