Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4825CDFB2 for ; Mon, 20 May 2013 18:55:33 +0000 (UTC) Received: (qmail 55209 invoked by uid 500); 20 May 2013 18:55:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 55162 invoked by uid 500); 20 May 2013 18:55:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 55144 invoked by uid 500); 20 May 2013 18:55:32 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 55129 invoked by uid 99); 20 May 2013 18:55:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2013 18:55:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 091FC1CA2C8; Mon, 20 May 2013 18:55:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4839547889600725922==" MIME-Version: 1.0 Subject: Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load From: "Chip Childers" To: "Chip Childers" Cc: "Prasanna Santhanam" , "cloudstack" Date: Mon, 20 May 2013 18:55:27 -0000 Message-ID: <20130520185527.13725.58431@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11238/ X-Sender: "Chip Childers" References: <20130520134620.13727.99671@reviews.apache.org> In-Reply-To: <20130520134620.13727.99671@reviews.apache.org> Reply-To: "Chip Childers" --===============4839547889600725922== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11238/#review20783 ----------------------------------------------------------- Ship it! Ship It! - Chip Childers On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11238/ > ----------------------------------------------------------- > = > (Updated May 20, 2013, 1:46 p.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors > = > Missing default constructor fails the agent manager reloading the XCP > resource on reboot of management server. This is fixed by using the > default constructor as do other Xen resources and include a new resou= rce > ala XenServers for XCP1.6. > = > Signed-off-by: Prasanna Santhanam > (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34) > = > Conflicts: > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xcp= ServerResource.java > = > Signed-off-by: Prasanna Santhanam > = > = > This addresses bug CLOUDSTACK-2554. > = > = > Diffs > ----- > = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServ= erDiscoverer.java 04982a5 = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHel= per.java 52641f6 = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer= 16Resource.java PRE-CREATION = > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer= Resource.java e4fc9ef = > = > Diff: https://reviews.apache.org/r/11238/diff/ > = > = > Testing > ------- > = > This was tested against the build from master with the BVT across xen 6.0= .2, kvm and xcp 1.6. > = > = > Thanks, > = > Prasanna Santhanam > = > --===============4839547889600725922==--