Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDC8ADBC5 for ; Wed, 15 May 2013 11:16:49 +0000 (UTC) Received: (qmail 87524 invoked by uid 500); 15 May 2013 11:16:48 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 87248 invoked by uid 500); 15 May 2013 11:16:48 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 87218 invoked by uid 500); 15 May 2013 11:16:47 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 87189 invoked by uid 99); 15 May 2013 11:16:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 May 2013 11:16:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2536D1C9D17; Wed, 15 May 2013 11:16:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1735805344665511429==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed adding same private gw twice From: "Kishan Kavala" To: "Kishan Kavala" , "Abhinandan Prateek" , "Alena Prokharchyk" , "Murali Reddy" Cc: "Jayapal Reddy" , "cloudstack" Date: Wed, 15 May 2013 11:16:41 -0000 Message-ID: <20130515111641.23050.7007@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kishan Kavala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11176/ X-Sender: "Kishan Kavala" References: <20130515101420.23050.34552@reviews.apache.org> In-Reply-To: <20130515101420.23050.34552@reviews.apache.org> Reply-To: "Kishan Kavala" --===============1735805344665511429== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11176/#review20571 ----------------------------------------------------------- Ship it! commit 9b6513466f5826d4932bf69dcf3a531f05ac625c - Kishan Kavala On May 15, 2013, 10:14 a.m., Jayapal Reddy wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11176/ > ----------------------------------------------------------- > = > (Updated May 15, 2013, 10:14 a.m.) > = > = > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, Murali = Reddy, and Alena Prokharchyk. > = > = > Description > ------- > = > Fixed adding same private gateway twice. > Fixed by not allowing same vlan/network twice. = > = > = > This addresses bug CLOUDSTACK-2369. > = > = > Diffs > ----- > = > engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDao.java 02df92e = > engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java ecab3= bb = > server/src/com/cloud/network/NetworkServiceImpl.java f3ec253 = > = > Diff: https://reviews.apache.org/r/11176/diff/ > = > = > Testing > ------- > = > 1. created new deployment, and added vpc > 2. added same private gateway twice. > 3. configuring gateway second time failed > = > = > Thanks, > = > Jayapal Reddy > = > --===============1735805344665511429==--