Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DA1711619 for ; Fri, 10 May 2013 12:52:31 +0000 (UTC) Received: (qmail 19235 invoked by uid 500); 10 May 2013 12:52:29 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 16389 invoked by uid 500); 10 May 2013 12:52:23 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 16301 invoked by uid 500); 10 May 2013 12:52:21 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 16287 invoked by uid 99); 10 May 2013 12:52:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2013 12:52:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 47E001C9867; Fri, 10 May 2013 12:52:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2276062850232185814==" MIME-Version: 1.0 Subject: Re: Review Request: ACL on private gateway feature From: "Jayapal Reddy" To: "Kishan Kavala" , "Abhinandan Prateek" , "Murali Reddy" Cc: "cloudstack" , "Jayapal Reddy" Date: Fri, 10 May 2013 12:52:16 -0000 Message-ID: <20130510125216.5514.64370@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jayapal Reddy" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10942/ X-Sender: "Jayapal Reddy" References: <20130509120846.5484.48132@reviews.apache.org> In-Reply-To: <20130509120846.5484.48132@reviews.apache.org> Reply-To: "Jayapal Reddy" --===============2276062850232185814== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/ ----------------------------------------------------------- (Updated May 10, 2013, 12:52 p.m.) Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Mural= i Reddy. Changes ------- Updated diff file. Description ------- ACL on private gateway feature. ACLs are implemented with the container model This addresses bug CLOUDSTACK-768. Diffs (updated) ----- api/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f = api/src/com/cloud/network/NetworkService.java bea92dc = api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 = api/src/com/cloud/network/firewall/NetworkACLService.java 5f068a3 = api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 = api/src/com/cloud/network/vpc/VpcService.java 23e2764 = api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayC= md.java 2055695 = api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLL= istCmd.java b8abc78 = core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.j= ava b9bda4d = patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh PRE-CRE= ATION = plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComp= utingResource.java 8fe8c88 = plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmwar= eResource.java 030eff0 = plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResou= rceBase.java bac361d = server/src/com/cloud/network/NetworkServiceImpl.java 7045eff = server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a = server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.jav= a 306b1a8 = server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl= .java 1d901d9 = server/src/com/cloud/network/vpc/NetworkACLManager.java 1b1e958 = server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 67547c6 = server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 2844dcb = server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db = server/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 = server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 = server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f = server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 = server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 = server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java ef54= 78b = server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java a483291 = setup/db/db/schema-410to420.sql 8fdf0a0 = Diff: https://reviews.apache.org/r/10942/diff/ Testing ------- 1. Tested creation of private gateway with acl id 2. replacenetworkacl for privategateway id 3. add new acl item and checking the applying item on private gw 4. restart router and see the rules are added or not. Thanks, Jayapal Reddy --===============2276062850232185814==--