Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67C63102BF for ; Wed, 8 May 2013 06:40:58 +0000 (UTC) Received: (qmail 78672 invoked by uid 500); 8 May 2013 06:40:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 78626 invoked by uid 500); 8 May 2013 06:40:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 78587 invoked by uid 500); 8 May 2013 06:40:55 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 78576 invoked by uid 99); 8 May 2013 06:40:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2013 06:40:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 60AF41C23AB; Wed, 8 May 2013 06:40:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7302433374915795463==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support From: "ASF Subversion and Git Services" To: "Animesh Chaturvedi" , "Fang Wang" , "Devdeep Singh" Cc: "Sanjay Tripathi" , "cloudstack" , "ASF Subversion and Git Services" Date: Wed, 08 May 2013 06:40:51 -0000 Message-ID: <20130508064051.5484.11645@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10836/ X-Sender: "ASF Subversion and Git Services" References: <20130507080659.5484.79918@reviews.apache.org> In-Reply-To: <20130507080659.5484.79918@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============7302433374915795463== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10836/#review20292 ----------------------------------------------------------- Commit b6cb23cb99c9daee41b46a3fc13fffabfb791dc3 in branch refs/heads/master= from Likitha Shetty [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3Db6cb23c ] CLOUDSTACK-957: Localization -- Add UK keyboard support. - ASF Subversion and Git Services On May 7, 2013, 8:06 a.m., Sanjay Tripathi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10836/ > ----------------------------------------------------------- > = > (Updated May 7, 2013, 8:06 a.m.) > = > = > Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chat= urvedi. > = > = > Description > ------- > = > CLOUDSTACK-957: Localization -- Add UK keyboard support. > = > - Added the support of UK keyboard by: > - Initialising the UK keyboard from the existing US keyboard mapping. > - Adding/Overriding the special keys support of UK keys which differ= from US keyboard. > - Also moved the JP keys initialisation to ajaxkeys.js file. > = > = > This addresses bug CLOUDSTACK-957. > = > = > Diffs > ----- > = > services/console-proxy/server/css/ajaxviewer.css 5ea552b = > services/console-proxy/server/js/ajaxkeys.js 2ecf5b5 = > services/console-proxy/server/js/ajaxviewer.js e95615d = > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyCl= ientBase.java 289bdab = > = > Diff: https://reviews.apache.org/r/10836/diff/ > = > = > Testing > ------- > = > Tests: > = > 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have te= sted on this). > 2) Go to VM detailView and open VM console view. > 3) Change input method for keyboard to UK language. > 4) Go to top of console-window and click on "keyboard" option to select U= K language. > 5) Start using UK keyboard (Make sure the input method of client keyboard= is UK (from where the user is pressing the keys)). > = > Tested on my local CloudStack setup by following above mentioned steps. > = > = > Thanks, > = > Sanjay Tripathi > = > --===============7302433374915795463==--