Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2783132522549320474=="
MIME-Version: 1.0
Subject: Re: Review Request:
 CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider
From: "Murali Reddy" <muralimmreddy@gmail.com>
To: "Vijay Venkatachalam" <vijay.venkatachalam@citrix.com>,
 "Ram Ganesh" <ram.ganesh@citrix.com>,
 "Kishan Kavala" <Kishan.Kavala@citrix.com>,
 "Murali Reddy" <muralimmreddy@gmail.com>,
 "Alena Prokharchyk" <alena.prokharchyk@citrix.com>
Cc: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "cloudstack" <cloudstack-dev@incubator.apache.org>
Date: Mon, 06 May 2013 15:36:29 -0000
Message-ID: <20130506153629.5514.90108@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Murali Reddy" <noreply@reviews.apache.org>
References: <20130430032840.17259.32402@reviews.apache.org>
In-Reply-To: <20130430032840.17259.32402@reviews.apache.org>
Reply-To: "Murali Reddy" <muralimmreddy@gmail.com>

--===============2783132522549320474==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20191
-----------------------------------------------------------


plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerE=
lement.java
<https://reviews.apache.org/r/10858/#comment41413>

    implement and shutdown need to be implemented? how would VLAN be config=
ured on NetScaler with out implementing network?


plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerE=
lement.java
<https://reviews.apache.org/r/10858/#comment41414>

    remove the TODO's, if there is no  need for method implementation and j=
ust return true


server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10858/#comment41422>

    same should hold for other external devices as well. so please put gene=
ric comment (with out netscaler)


- Murali Reddy


On April 30, 2013, 3:28 a.m., Rajesh Battala wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> -----------------------------------------------------------
> =

> (Updated April 30, 2013, 3:28 a.m.)
> =

> =

> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena Prokhar=
chyk, Vijay Venkatachalam, and Ram Ganesh.
> =

> =

> Description
> -------
> =

> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with al=
l the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a =

>   plugins/network-elements/netscaler/src/com/cloud/network/element/Netsca=
lerElement.java 2bbdb04 =

>   server/src/com/cloud/network/NetworkServiceImpl.java 2dcb47d =

>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db =

>   server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 =

>   server/test/com/cloud/vpc/ChildTestConfiguration.java PRE-CREATION =

>   server/test/com/cloud/vpc/VpcManagerTest.java PRE-CREATION =

>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOffering=
Test.java cbb6c00 =

>   server/test/resources/VpcContext.xml PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/10858/diff/
> =

> =

> Testing
> -------
> =

> Manual Testing:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> 1. Creation of Vpc with the default offering with NS is created successfu=
lly. ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfu=
lly.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider wit=
h dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider wit=
h shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is c=
reated successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. =

> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier c=
idr range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netsca=
ler device and necessary configuration is created and LB rule is created on=
 NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is clea=
red
> 20. Deletion of tier will mark the netscaler to be in free mode.
> =

> =

> Unit Test:
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> =

> =

> Thanks,
> =

> Rajesh Battala
> =

>


--===============2783132522549320474==--