Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C9C3FEF8 for ; Thu, 2 May 2013 17:31:28 +0000 (UTC) Received: (qmail 2661 invoked by uid 500); 2 May 2013 17:31:27 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 2628 invoked by uid 500); 2 May 2013 17:31:27 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 2617 invoked by uid 500); 2 May 2013 17:31:27 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 2609 invoked by uid 99); 2 May 2013 17:31:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 17:31:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 712E31C9465; Thu, 2 May 2013 17:31:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2788828619739922501==" MIME-Version: 1.0 Subject: Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes From: "ASF Subversion and Git Services" To: "Chip Childers" Cc: "cloudstack" , "ASF Subversion and Git Services" , "Wei Zhou" Date: Thu, 02 May 2013 17:31:23 -0000 Message-ID: <20130502173123.17259.1357@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10904/ X-Sender: "ASF Subversion and Git Services" References: <20130502153604.17260.87983@reviews.apache.org> In-Reply-To: <20130502153604.17260.87983@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============2788828619739922501== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10904/#review20087 ----------------------------------------------------------- Commit f8504c096054d638fb5ed1e21e55243653c4649a in branch refs/heads/ui-cis= co-asa1000v-support from Chip Childers [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3Df8504c0 ] CLOUDSTACK-2303: fix upgrade failed from 2.2.14 to 4.1.0 for systemvm chang= es The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release= _Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf) However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-e= n-US.pdf) so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java. Signed-off-by: Chip Childers - ASF Subversion and Git Services On May 2, 2013, 3:36 p.m., Wei Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10904/ > ----------------------------------------------------------- > = > (Updated May 2, 2013, 3:36 p.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http= ://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Not= es/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf) > However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http:/= /dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.p= df) > so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystem= Vms in Upgrade2214to30.java. > = > = > This addresses bug CLOUDSTACK-2303. > = > = > Diffs > ----- > = > server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec = > = > Diff: https://reviews.apache.org/r/10904/diff/ > = > = > Testing > ------- > = > Testing manually ok. > = > = > Thanks, > = > Wei Zhou > = > --===============2788828619739922501==--