Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEB5BF3EA for ; Thu, 2 May 2013 07:03:18 +0000 (UTC) Received: (qmail 31329 invoked by uid 500); 2 May 2013 07:03:18 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 31260 invoked by uid 500); 2 May 2013 07:03:18 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 31227 invoked by uid 500); 2 May 2013 07:03:17 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 31213 invoked by uid 99); 2 May 2013 07:03:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 07:03:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B24C21C82E4; Thu, 2 May 2013 07:03:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3673643977412368907==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUDSTACK-1851 [AWS Style Health Checks] Health Check monitor not getting created on Netscaler device in Basic zone setup. From: "Rajesh Battala" To: "Ram Ganesh" , "Vijay Venkatachalam" , "Murali Reddy" Cc: "Rajesh Battala" , "cloudstack" Date: Thu, 02 May 2013 07:03:12 -0000 Message-ID: <20130502070312.17260.56523@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rajesh Battala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10572/ X-Sender: "Rajesh Battala" References: <20130502055323.17259.52022@reviews.apache.org> In-Reply-To: <20130502055323.17259.52022@reviews.apache.org> Reply-To: "Rajesh Battala" --===============3673643977412368907== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On May 2, 2013, 5:53 a.m., Murali Reddy wrote: > > commit 16865014a05ab04bb608a8122a7229b2b0ae3421 > > Author: Rajesh Battala > > Date: Wed Apr 17 18:22:30 2013 +0530 Thanks alot Murali - Rajesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10572/#review20057 ----------------------------------------------------------- On April 17, 2013, 1:20 p.m., Rajesh Battala wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10572/ > ----------------------------------------------------------- > = > (Updated April 17, 2013, 1:20 p.m.) > = > = > Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram= Ganesh. > = > = > Description > ------- > = > Fixed the issue > 1.While creating the LB rule, healthcheck policies were not sent, so they= are not getting created. Fixed the issue by including them in TO construct= or. > 2. Fetching the status of healthchecks created in basic zone. > = > = > This addresses bug CLOUDSTACK-1851. > = > = > Diffs > ----- > = > plugins/network-elements/netscaler/src/com/cloud/network/element/Netsca= lerElement.java 2bbdb04 = > = > Diff: https://reviews.apache.org/r/10572/diff/ > = > = > Testing > ------- > = > Created basiczone setup with Netscaler. > = > 1. Verified creation/deletion of healthchecks on LB rules > 2. Verified creation of healthchecks with different param values. > 3. Verified the Healthcheck manager is updating the status of the service= s in the lb vm map table. > 4. Verified deletion of healthchecks, resetting the status of services to= null > 5. Deletion of healthcheck will do clean up of healthcheck entires in clo= udstack db and in Netscaler resource. > = > = > Thanks, > = > Rajesh Battala > = > --===============3673643977412368907==--