Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0DFFF377 for ; Thu, 2 May 2013 05:12:50 +0000 (UTC) Received: (qmail 76368 invoked by uid 500); 2 May 2013 05:12:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 76313 invoked by uid 500); 2 May 2013 05:12:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 76271 invoked by uid 500); 2 May 2013 05:12:48 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 76261 invoked by uid 99); 2 May 2013 05:12:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 05:12:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CFF611C9473; Thu, 2 May 2013 05:12:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6742769858550259062==" MIME-Version: 1.0 Subject: Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory From: "mice xia" To: "Prasanna Santhanam" , "mice xia" , "Likitha Shetty" Cc: "cloudstack" , "Hongtu Zang" Date: Thu, 02 May 2013 05:12:44 -0000 Message-ID: <20130502051244.17260.63288@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "mice xia" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10750/ X-Sender: "mice xia" References: <20130424042029.22548.87679@reviews.apache.org> In-Reply-To: <20130424042029.22548.87679@reviews.apache.org> Reply-To: "mice xia" --===============6742769858550259062== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10750/#review20048 ----------------------------------------------------------- Ship it! Ship It! - mice xia On April 24, 2013, 4:20 a.m., Hongtu Zang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10750/ > ----------------------------------------------------------- > = > (Updated April 24, 2013, 4:20 a.m.) > = > = > Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mi= ce xia. > = > = > Description > ------- > = > fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of = memory > = > modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 = unused ips. > = > = > This addresses bug CLOUDSTACK-2160. > = > = > Diffs > ----- > = > server/src/com/cloud/network/NetworkModelImpl.java c5930d9 = > server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45 = > utils/src/com/cloud/utils/net/NetUtils.java 5988dd5 = > = > Diff: https://reviews.apache.org/r/10750/diff/ > = > = > Testing > ------- > = > create a new network with netmask 255.0.0.0 and it won't cause out of mem= ory > = > = > Thanks, > = > Hongtu Zang > = > --===============6742769858550259062==--