cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Likitha Shetty <likitha.she...@citrix.com>
Subject RE: [MERGE] Dedicate guest vlan ranges to account
Date Thu, 02 May 2013 05:28:00 GMT
Thanks for taking a look Hugo.
I will update the branch with the fixes.

Thanks,
Likitha

>-----Original Message-----
>From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>Sent: Wednesday, May 01, 2013 5:07 PM
>To: dev@cloudstack.apache.org
>Subject: RE: [MERGE] Dedicate guest vlan ranges to account
>
>Likitha,
>
>Couple of remarks on the merge request:
>
>I think the calls you added to the system should fail with an informative error
>message if the physical network does not have the isolation type VLAN, as your
>code is only usable in networks with VLAN style isolation.
>
>Can you double check your formatting and line endings of the new files? For
>example DedicateGuestVlanRangeCmd.java seems to have windows style line
>endings.
>
> I also noticed some files with changed permissions (from 644 to 755) (in one
>case without any changes in the file itself).  Can you fix that? Permissions should
>be 644 for java code.
>
>Cheers,
>
>Hugo
>
>> -----Original Message-----
>> From: Likitha Shetty [mailto:likitha.shetty@citrix.com]
>> Sent: Wednesday, May 01, 2013 12:39 PM
>> To: dev@cloudstack.apache.org
>> Subject: [MERGE] Dedicate guest vlan ranges to account
>>
>> Hi all,
>>
>> I would like to merge the feature Dedicate Guest VLAN range to master.
>>
>> Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
>> FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-
>> +Dedicate+Guest+VLANs+per+tenant
>> Branch - dedicate-guest-vlan-ranges_2 (was developed in branch
>> dedicate-
>> guest-vlan-ranges) Unit tests -  Unit tests for the new API's can be
>> found at
>> server/test/com/cloud/network/DedicateGuestVlanRangesTest.java
>> Integration tests - Python tests can be found be found at
>> test/integration/smoke/test_guest_vlan_range.py
>> Rebased the branch with master - Commit id:
>> 807ad0a39ab272a4af2de3156b0b367570acccea
>> RAT - RAT build is successful and no new dependencies introduced
>>
>> Thanks,
>> Likitha

Mime
View raw message