cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jessica Wang <Jessica.W...@citrix.com>
Subject RE: Create View Question
Date Fri, 31 May 2013 21:28:56 GMT
Nitin,

I added volume_view to schema-410to420.sql first.


I added volume_view at line 718 ~ line 818:
-------------------------------------------------------------------------------------------
Author:		Jessica Wang <jessicawang@apache.org>#mailto:jessicawang@apache.org
Author date:	1 month ago (Tue Apr 23 11:23:49 2013)
Commit date:	1 month ago (Tue Apr 23 13:01:55 2013)
Commit hash:	35e2072660d20b538bf6929d9c68eecb16ac8318

CLOUDSTACK-2120: mixed zone management - extend listVolumes API to return zone type.

Contained in branches: master
Contained in no tag
-------------------------------------------------------------------------------------------


Two days later, you added another duplicate volume_view at line 1571 ~ line 1672:
-------------------------------------------------------------------------------------------
Author:		Nitin Mehta <nitin.mehta@citrix.com>#mailto:nitin.mehta@citrix.com
Author date:	1 month ago (Thu Apr 25 00:11:46 2013)
Commit date:	1 month ago (Thu Apr 25 05:59:57 2013)
Commit hash:	d1642a489ce76e055d60b2caf3ccfe4bb136b745

=initial changes

Contained in branches: master
Contained in no tag
-------------------------------------------------------------------------------------------


Please drop one of them.

Thank you.

Jessica


-----Original Message-----
From: Min Chen 
Sent: Thursday, May 30, 2013 9:57 AM
To: Nitin Mehta; dev@cloudstack.apache.org
Cc: Jessica Wang
Subject: Re: Create View Question

Please work with Jessica to consolidate the two views created by you two
to come up with a final volume_view.

Thanks
-min

On 5/30/13 6:46 AM, "Nitin Mehta" <Nitin.Mehta@citrix.com> wrote:

>Sorry for missing the mail. I would need the new volume view for my
>feature to work.
>
>On 24/05/13 1:45 AM, "Min Chen" <min.chen@citrix.com> wrote:
>
>>It is related to this commit d1642a489ce76e055d60b2caf3ccfe4bb136b745.
>>Schema-410to420.sql should have one section to define the new volume_view
>>for 4.2.0. 
>>CC Nitin here to see if his new volume_view should be used or the one
>>before his commit in this file.
>>
>>THanks
>>-min
>>
>>
>>On 5/23/13 12:50 PM, "Mike Tutkowski" <mike.tutkowski@solidfire.com>
>>wrote:
>>
>>>Hi,
>>>
>>>I've added a few fields (min, max, burst IOPS) to two tables and - in
>>>the
>>>process - noticed the following view is dropped and created twice:
>>>
>>>DROP VIEW IF EXISTS `cloud`.`volume_view`;
>>>CREATE VIEW `cloud`.`volume_view` AS
>>>
>>>I assume this is a bug and have removed (in my sandbox) the
>>>first occurrence.
>>>
>>>If anyone knows of a reason why we want to keep this code as is, please
>>>let
>>>me know as this change will otherwise be submitted when I submit my code
>>>for review tomorrow or early next week.
>>>
>>>Thanks!
>>>
>>>-- 
>>>*Mike Tutkowski*
>>>*Senior CloudStack Developer, SolidFire Inc.*
>>>e: mike.tutkowski@solidfire.com
>>>o: 303.746.7302
>>>Advancing the way the world uses the
>>>cloud<http://solidfire.com/solution/overview/?video=play>
>>>**
>>
>

Mime
View raw message