cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pranav Saxena <pranav.sax...@citrix.com>
Subject [MERGED] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
Date Fri, 31 May 2013 04:37:50 GMT
UI support for explicit dedication of resources has now been merged into master . People willing
to test and document this feature could pick it up now . 

Thanks,
Pranav

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com] 
Sent: Friday, May 31, 2013 1:23 AM
To: dev@cloudstack.apache.org
Cc: Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)

On Thu, May 30, 2013 at 05:38:18PM +0000, Pranav Saxena wrote:
> So currently they are not localized. Usually we localize all the labels , dialog messages
 whenever a feature is into master and I had planned to do the same with this one as well
.  Since that doesn't affect the feature functionality , I thought of merging the feature
before so that people(QA ) could pick it up and start testing it (which gives them more time
testing a feature) and meanwhile I could localize the various entities simultaneously. 
> 
> If you are ok with it , I shall merge the feature or if you want the strings to be localized
first I can do that as well . 

I'm good with your approach.  I was only asking out of interest.

> 
> Thanks,
> Pranav
> 
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com] 
> Sent: Thursday, May 30, 2013 10:54 PM
> To: Pranav Saxena
> Cc: dev@cloudstack.apache.org; Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
> Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
> 
> On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> > Thanks Chip for reminding me of that . I have rebased my branch off latest master
now  and there are no conflicts . Please go ahead and have a look at the diff . 
> > Please let me know in case there are any concerns.
> > 
> > Thanks,
> > Pranav
> 
> Thanks!
> 
> I have a question, but +1 from me.
> 
> Question:
> 
> Generally, I see lots of static strings that assume en-US in the patch (which seems to
follow the existing patterns).  How are those strings localized?  Or are they not?  
> 
> This is my first time reviewing UI code in depth, hence the question (I wanted to see
how a feature like this was pulled together... it's a good model!).
> 
> Examples in:
> ui/scripts/docs.js
> ui/scripts/system.js
> 
> These include labels, error messages, dialog messages, etc...
> 
> -chip
> 

Mime
View raw message