cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Hornyak" <laszlo.horn...@gmail.com>
Subject Re: Review Request: test and cleanup for getBase64Keystore
Date Fri, 31 May 2013 01:13:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11563/
-----------------------------------------------------------

(Updated May 31, 2013, 1:13 a.m.)


Review request for cloudstack.


Description
-------

ConfigurationServerImpl.getBase64Keystore did not close the file input stream correctly. This
patch adds test and replaces the file read with commons-io FileUtils call.


Diffs
-----

  server/pom.xml 6385bf2 
  server/src/com/cloud/server/ConfigurationServerImpl.java 35f977b 
  server/test/com/cloud/server/ConfigurationServerImplTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11563/diff/


Testing
-------

test included


Thanks,

Laszlo Hornyak


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message