cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <>
Subject Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
Date Fri, 31 May 2013 01:01:39 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 31, 2013, 1:01 a.m.)

Review request for cloudstack, Abhinandan Prateek and edison su.


Adding Abhi as reviewer


Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

In file, function generateSetupCommand, if the host type
is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage
host stauts should become Up.

The secondary storage host always remains Alert status, because before the secondary storage
vm is deployed, the secondary storage host is created. The tricky way (in the end of file, function NotifiMonitorsOfConnection) will try to disconnect secondary
storage, therefore the secondary storage host becomes Alert status. The code should take SSVM
into consider, not only Answer reponse.

File, function discoverHostsFull, in the end will call discoverer.postDiscovery,
in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed
since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl.
This makes why secondary storage host always remains Alert status.

This addresses bug


  server/src/com/cloud/agent/manager/ c1bbb58 
  server/src/com/cloud/storage/secondary/ 3ca74a3 
  server/src/com/cloud/storage/secondary/ 46ac7af 



Test 4.0.0, 4.2.0 in basic mode, works well.


roxanne chang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message